fix: Babele-2.9.1-Wörterbuch-Lookups repariert + Zauberformel-Timing-Fix

game.babele.translate(pack, {name: value}) liefert in der installierten
Babele-Version bei jedem Aufruf den unveraenderten Input zurueck, egal ob
eine Uebersetzung existiert. Betroffen waren career_careergroup_fn,
career_skills_fn, career_talents sowie alle Zweige von bestiary_traits
(Trait/Skill/Prayer/Spell/Talent/Career/VehicleRole/Trapping) in
babele-register.js - dadurch blieben Karrierenamen wie "Agitator"
unuebersetzt (mit Fehlermeldung im Chat) und NPC-Zauberformeln enthielten
noch rohen englischen Text.

Fix: eigene compendium/*.json-Woerterbuecher direkt per fetch() einlesen
und in __dictCaches cachen, statt sich auf Babeles translate() zu
verlassen. Cache-Aufbau in den 'ready'-Hook verschoben (game.wfrp4e
existiert waehrend 'babele.init' noch nicht garantiert).

parseSpellContent laeuft in bestiary_traits jetzt unabhaengig davon, ob
der Zauber/das Gebet einen Woerterbuchtreffer hat - vorher blieb die
Formel-Korrektur bei fehlendem Treffer komplett aus. Zusaetzlich
OvercastItemModel.prototype.computeSpellDamage in addon-register.js
gepatcht, damit auch rohe englische Bonus-Phrasen ("Toughness Bonus")
erkannt werden, unabhaengig vom Uebersetzungs-Timing (trat u.a. beim
Laden von Journal-Link-Vorschauen auf, wo unsere Konverter noch nicht
gelaufen waren).

Ausserdem die deaktivierte Chat-Abschlussmeldung ("Shallya"-Segen) in
addon-register.js wieder aktiviert und so verkabelt, dass sie auf den
tatsaechlichen Abschluss der __dictCaches-Ladevorgaenge wartet statt auf
einen festen Timeout.
This commit is contained in:
alzer
2026-09-28 20:19:12 +02:00
parent 9d6af8cc73
commit ba35a60e4a
3 changed files with 195 additions and 186 deletions
+1 -1
View File
@@ -8,7 +8,7 @@
} }
], ],
"url": "https://gitea.palmenalzer.de/alzer/wfrp-4e-de", "url": "https://gitea.palmenalzer.de/alzer/wfrp-4e-de",
"version": "8.7.13", "version": "8.7.17",
"esmodules": [ "esmodules": [
"modules/babele-register.js", "modules/babele-register.js",
"modules/addon-register.js", "modules/addon-register.js",
+47 -5
View File
@@ -232,11 +232,18 @@ const __check_fix_wrong_modules = (chatFlag, patchFinished) => {
}); });
} }
} else { } else {
if (false && game.user.isGM && patchFinished) { if (game.user.isGM && patchFinished) {
ChatMessage.create({ // Wait for babele-register.js's dictionary caches (career/skill/trait/prayer/
content: "<div>Die WFRP4E-Module wurden <strong>erfolgreich</strong> übersetzt. Du kannst loslegen und <strong>möge Shallya dich behüten</strong></div>", // spell/talent/vehicleRole/trapping - used by career_careergroup_fn and
user: game.user.id, // bestiary_traits) to actually finish loading before announcing completion,
whisper: ChatMessage.getWhisperRecipients("GM") // rather than relying on this function's fixed 20s setTimeout delay alone -
// that delay predates those caches and isn't guaranteed to outlast them.
Promise.resolve(game.wfrp4efr?.dictCachesReady).finally(() => {
ChatMessage.create({
content: "<div>Die WFRP4E-Module wurden <strong>erfolgreich</strong> übersetzt. Du kannst loslegen und <strong>möge Shallya dich behüten</strong></div>",
user: game.user.id,
whisper: ChatMessage.getWhisperRecipients("GM")
});
}); });
} }
} }
@@ -469,6 +476,41 @@ Hooks.on('ready', () => {
}; };
} }
// Patch OvercastItemModel.prototype.computeSpellDamage (shared by SpellModel and
// PrayerModel, both `extends OvercastItemModel`) to also recognize raw English
// characteristic-bonus phrases in the damage formula, not just the current locale's.
// The system's own implementation does
// `formula.replace(game.wfrp4e.config.characteristicsBonus[ch].toLowerCase(), ...)`,
// which only ever tries the CURRENT (German) localized text - e.g. "widerstandsbonus"
// for Toughness. If a spell/prayer's damage.value formula is still raw English (e.g.
// "Toughness Bonus+4"), because the document was loaded through a path where Babele's
// translation converters run too late to matter for this field (observed via a journal
// page's link-preview priming, which constructs the full Item/Actor - and immediately
// evaluates derived data - before our custom converters get a chance to rewrite the
// formula text), the replace never matches and the leftover text throws a SyntaxError
// when eval()'d. This tries the English phrase too, as a fallback, so the formula
// evaluates correctly regardless of translation timing.
const overcastProto = Object.getPrototypeOf(CONFIG.Item.dataModels.spell?.prototype ?? {});
if (overcastProto?.computeSpellDamage) {
const originalComputeSpellDamage = overcastProto.computeSpellDamage;
const EN_CHARACTERISTICS_BONUS = {
"ws": "weapon skill bonus", "bs": "ballistic skill bonus", "s": "strength bonus",
"t": "toughness bonus", "i": "initiative bonus", "ag": "agility bonus",
"dex": "dexterity bonus", "int": "intelligence bonus", "wp": "willpower bonus", "fel": "fellowship bonus"
};
overcastProto.computeSpellDamage = function (formula, options) {
if (typeof formula === "string") {
const lower = formula.toLowerCase();
for (const [abbr, enPhrase] of Object.entries(EN_CHARACTERISTICS_BONUS)) {
if (!lower.includes(enPhrase)) continue;
const dePhrase = game.wfrp4e.config.characteristicsBonus?.[abbr]?.toLowerCase();
if (dePhrase) formula = formula.replace(new RegExp(enPhrase, "ig"), dePhrase);
}
}
return originalComputeSpellDamage.call(this, formula, options);
};
}
game.wfrp4e.warnDialog.render(true, { focus: true, left: 20, top: 20 }); game.wfrp4e.warnDialog.render(true, { focus: true, left: 20, top: 20 });
//setTimeout( __check_fix_wrong_modules, 2000, true, false); //setTimeout( __check_fix_wrong_modules, 2000, true, false);
setTimeout(__check_fix_wrong_modules, 20000, true, true); setTimeout(__check_fix_wrong_modules, 20000, true, true);
+147 -180
View File
@@ -142,6 +142,49 @@ Hooks.once('init', () => {
// pack "loaded" (JSON parsed) but with no effective mapping applied - which is // pack "loaded" (JSON parsed) but with no effective mapping applied - which is
// exactly the "everything stays English except journals" symptom. // exactly the "everything stays English except journals" symptom.
// See: https://gitlab.com/riccisi/foundryvtt-babele/-/raw/master/DEVELOPER_MIGRATION_2_8_0.md // See: https://gitlab.com/riccisi/foundryvtt-babele/-/raw/master/DEVELOPER_MIGRATION_2_8_0.md
// Every converter below used to resolve an English item name (a career
// mentioned inline in another document's text, a skill in a career's skill
// list, a bestiary trait/prayer/spell/talent/trapping on an NPC, ...) to
// German by calling game.babele.translate(pack, {name, ...}, ...). That no
// longer works in the installed Babele version: matching is driven entirely
// by mapping.matchKeyCandidates(), which returns no candidates for a bare
// stub object, so the call silently falls through and returns the input
// unchanged for EVERY name, matched or not (verified live - even definite,
// unambiguous entries like the "Charm" skill or the "Spy" career come back
// unchanged). The old code detected "no match" by comparing the result
// against the input, which is doubly wrong here: it never once succeeds, and
// even if it had, it would mislabel any German name that happens to be
// spelled like its English source (e.g. "Agitator", "Slayer", "Duellist") as
// untranslated.
// Fix: read our own compendium/*.json dictionaries directly (same files
// Babele itself loads via dir:'compendium'), bypassing Babele's matcher.
// __dictCaches[tag] is a Map<EnglishKey, rawDictionaryEntry> built once from
// every pack tagged with `tag`, in priority order (first pack with an entry
// for a given key wins), mirroring the old "break on first match" loops.
const __dictCaches = {};
async function __buildDictCache(...validCompendiums) {
const cache = new Map();
// Fetch every pack's dictionary in parallel (there can be a dozen+ packs per
// tag, e.g. "spell"), then merge sequentially in pack order so the "first
// pack wins" precedence from the old per-lookup loops is preserved.
const fetched = await Promise.all(validCompendiums.map(async (compData) => {
try {
const resp = await fetch(`modules/wh4-de-translation/compendium/${compData.metadata.id}.json`);
if (!resp.ok) return null;
return await resp.json();
} catch (e) {
console.warn(`WFRP4E-DE | Konnte Wörterbuch für ${compData.metadata.id} nicht laden`, e);
return null;
}
}));
for (const data of fetched) {
for (let [enName, entry] of Object.entries(data?.entries ?? {})) {
if (!cache.has(enName) && entry?.name) cache.set(enName, entry);
}
}
return cache;
}
Hooks.once('babele.init', () => { Hooks.once('babele.init', () => {
if (typeof game.babele !== 'undefined') { if (typeof game.babele !== 'undefined') {
@@ -155,65 +198,41 @@ Hooks.once('babele.init', () => {
// Pre-define functions for cross-converter calls (Babele 2.8+ wraps converters // Pre-define functions for cross-converter calls (Babele 2.8+ wraps converters
// as objects, so game.babele.converters.X() no longer works as a plain call) // as objects, so game.babele.converters.X() no longer works as a plain call)
const career_skills_fn = (skills_list) => { const career_skills_fn = (skills_list) => {
let validCompendiums = game.wfrp4e.tags.getPacksWithTag("skill")
//DEBUG: console.log( "Thru here ...", compendium, skills_list);
if (skills_list) { if (skills_list) {
let i;
let len = skills_list.length;
let re = /(.*)\((.*)\)/i; let re = /(.*)\((.*)\)/i;
for (i = 0; i < len; i++) { for (let i = 0; i < skills_list.length; i++) {
skills_list[i] = skills_list[i].trim(); skills_list[i] = skills_list[i].trim();
for (let compData of validCompendiums) { let transl = __dictCaches.skill?.get(skills_list[i])?.name;
let translItem = game.babele.translate(compData.metadata.id, { name: skills_list[i], type: "skill" }, true) if (!transl) {
let transl = translItem?.name || undefined // Grouped skill with a specialization, e.g. "Art (Painting)": look up
if (!transl) transl = skills_list[i] // the group's own template entry ("Art ()"/"Art ( )") for the German
if (transl == skills_list[i]) { // group name, and localize the specialization word separately.
let res = re.exec(skills_list[i]); let res = re.exec(skills_list[i]);
if (res) { if (res) {
let subword = game.i18n.localize(res[2].trim()); let subword = game.i18n.localize(res[2].trim());
let s1 = res[1].trim() + " ()"; let base = res[1].trim();
translItem = game.babele.translate(compData.metadata.id, { name: s1, type: "skill" }, true) let template = __dictCaches.skill?.get(base + " ()")?.name ?? __dictCaches.skill?.get(base + " ( )")?.name;
let translw = translItem?.name || undefined let res2 = template ? re.exec(template) : null;
if (translw && translw != s1) { transl = (res2 ? res2[1].trim() : base) + " (" + subword + ")";
let res2 = re.exec(translw);
transl = res2[1].trim() + " (" + subword + ")";
} else {
s1 = res[1].trim() + " ( )";
translItem = game.babele.translate(compData.metadata.id, { name: s1, type: "skill" }, true)
translw = translItem?.name || undefined
if (translw) {
let res2 = re.exec(translw);
transl = res2[1].trim() + " (" + subword + ")";
} else {
transl = res[1].trim() + " (" + subword + ")";
}
}
}
} }
skills_list[i] = transl;
if (translItem?.system)
break;
} }
skills_list[i] = transl || skills_list[i];
} }
} }
return skills_list return skills_list
}; };
const career_careergroup_fn = (value) => { const career_careergroup_fn = (value) => {
if (value == 'Slayer') return "Slayer"; let entry = __dictCaches.career?.get(value);
if (entry?.name) return entry.name;
// Dictionary lookups that don't exist under their English career name at all
// (e.g. "Druidic Priest" isn't a literal key in any compendium/*.json) stay
// hardcoded here rather than forcing a fake dictionary entry for them.
if (value == 'Druidic Priest') return "Druide"; if (value == 'Druidic Priest') return "Druide";
let validCompendiums = game.wfrp4e.tags.getPacksWithTag("career"); if (!__dictCaches.career) {
// Try every career-tagged pack (core + supplements like Up in Arms, Archives, EIS, ...) // Cache not built yet (called before babele.init's fetches resolved) -
// before giving up - a career group's defining career may only exist in one of them, // return the English name rather than a false "not translated" error.
// so returning after the first pack silently left it untranslated whenever that pack return value;
// happened not to be the one with the match (e.g. "Spy" only exists in wfrp4e-core).
// IMPORTANT: game.babele.translate() returns the ORIGINAL stub object unchanged when a
// pack has no matching dictionary entry - it never returns null/undefined - so `newName`
// is truthy even on a miss (it's just `value` again). Must compare against `value` to
// detect an actual match, otherwise the very first pack always "wins" by default.
for (let compData of validCompendiums) {
let newName = game.babele.translate(compData.metadata.id, { name: value })?.name;
if (newName && newName !== value) return newName;
} }
ui.notifications.error("Das Übersetzen der Karriere " + value + " ist nicht möglich. Sie ist wahrscheinlich nicht übersetzt.", { permanent: true }); ui.notifications.error("Das Übersetzen der Karriere " + value + " ist nicht möglich. Sie ist wahrscheinlich nicht übersetzt.", { permanent: true });
return value; return value;
@@ -312,41 +331,29 @@ Hooks.once('babele.init', () => {
}, },
"career_talents": (talents_list) => { "career_talents": (talents_list) => {
let validCompendiums = game.wfrp4e.tags.getPacksWithTag("talent")
let i;
if (talents_list) { if (talents_list) {
let len = talents_list.length;
let re = /(.*)\((.*)\)/i; let re = /(.*)\((.*)\)/i;
for (i = 0; i < len; i++) { for (let i = 0; i < talents_list.length; i++) {
for (let compData of validCompendiums) { // Specific case management: "Trapper"/"Inspiring" collide with another
let translItem = game.babele.translate(compData.metadata.id, { name: talents_list[i] }, true); // document's name in the raw dictionary, so those two are looked up by
// Specific case management // their stable GUID key instead (see the identical special-case in the
if (talents_list[i] === "Trapper") { // "talent" branch of bestiary_traits below).
translItem = game.babele.translate(compData.metadata.id, { name: "a7v422EZcOUUC20X" }, true); let key = talents_list[i];
} if (key === "Trapper") key = "a7v422EZcOUUC20X";
if (talents_list[i] === "Inspiring") { if (key === "Inspiring") key = "WCXnFSV4WOSmzzc4";
translItem = game.babele.translate(compData.metadata.id, { name: "WCXnFSV4WOSmzzc4" }, true); let transl = __dictCaches.talent?.get(key)?.name;
} if (!transl) {
//console.log("Search talent name:", compData.metadata.id, talents_list[i], translItem); let res = re.exec(talents_list[i]);
let transl = translItem?.name || undefined if (res) {
if (!transl) transl = talents_list[i] let subword = game.i18n.localize(res[2].trim());
if (transl == talents_list[i]) { let s1 = res[1].trim(); // No () in talents table
let res = re.exec(talents_list[i]); let baseTransl = __dictCaches.talent?.get(s1)?.name;
if (res) { if (baseTransl && baseTransl != s1) {
let subword = game.i18n.localize(res[2].trim()); transl = baseTransl.trim() + " (" + subword + ")";
let s1 = res[1].trim(); // No () in talents table
translItem = game.babele.translate(compData.metadata.id, { name: s1 }, true)
let translw = translItem?.name || undefined
//console.log("Search talent name:", compData.metadata.id, s1, translw);
if (translw && translw != s1) {
transl = translw.trim() + " (" + subword + ")";
}
} }
} }
talents_list[i] = transl;
if (translItem?.system)
break;
} }
talents_list[i] = transl || talents_list[i];
} }
} }
return talents_list; return talents_list;
@@ -404,20 +411,15 @@ Hooks.once('babele.init', () => {
special = " (" + game.i18n.localize(res[2].trim()) + ")"; // And the special keyword special = " (" + game.i18n.localize(res[2].trim()) + ")"; // And the special keyword
} }
} }
let validCompendiums = game.wfrp4e.tags.getPacksWithTag("trait") let trait_fr = __dictCaches.trait?.get(name_en);
for (let compData of validCompendiums) { if (trait_fr?.name) {
let trait_fr = game.babele.translate(compData.metadata.id, { name: name_en, system: { description: { value: trait_en.system.description.value } } }, true) trait_en.name = nbt + trait_fr.name + special;
if (trait_fr?.name && trait_fr?.name != name_en) { if (trait_en.system?.description?.value && trait_fr.description) {
trait_fr.name = trait_fr.name || trait_en.name trait_en.system.description.value = trait_fr.description;
trait_en.name = nbt + trait_fr.name + special; }
if (trait_en.system?.description?.value && trait_fr.system?.description?.value) { if (trait_en?.system?.specification && isNaN(trait_en.system.specification?.value)) { // This is a string, so translate it
trait_en.system.description.value = trait_fr.system.description.value; //console.log("Translating : ", trait_en.system.specification.value);
} trait_en.system.specification.value = game.i18n.localize(trait_en.system.specification.value.trim());
if (trait_en?.system?.specification && isNaN(trait_en.system.specification?.value)) { // This is a string, so translate it
//console.log("Translating : ", trait_en.system.specification.value);
trait_en.system.specification.value = game.i18n.localize(trait_en.system.specification.value.trim());
}
break // Translation has been found, skip other compendiums
} }
} }
} else if (trait_en.type == "skill") { } else if (trait_en.type == "skill") {
@@ -430,46 +432,30 @@ Hooks.once('babele.init', () => {
special = " (" + game.i18n.localize(res[2].trim()) + ")"; // And the special keyword special = " (" + game.i18n.localize(res[2].trim()) + ")"; // And the special keyword
} }
} }
let validCompendiums = game.wfrp4e.tags.getPacksWithTag("skill") let trait_fr = __dictCaches.skill?.get(name_en);
for (let compData of validCompendiums) { if (trait_fr?.name) {
let trait_fr = game.babele.translate(compData.metadata.id, { name: name_en, system: { description: { value: trait_en.system.description.value } } }, true) trait_en.name = trait_fr.name + special;
//console.log(">>>>> Skill ?", name_en, special, trait_fr.name, trait_fr); if (trait_fr.description) trait_en.system.description.value = trait_fr.description;
if (trait_fr?.name && trait_fr?.name != name_en) {
trait_fr.name = trait_fr.name || name_en
trait_en.name = trait_fr.name + special;
trait_en.system.description.value = trait_fr.system.description.value;
break; // Translation has been found, skip other compendiums
}
} }
} else if (trait_en.type == "prayer") { } else if (trait_en.type == "prayer") {
let validCompendiums = game.wfrp4e.tags.getPacksWithTag("prayer") // parseSpellContent must run regardless of whether this prayer's name has a
for (let compData of validCompendiums) { // dictionary entry: the wfrp4e system's own damage-formula evaluator matches
let trait_fr = game.babele.translate(compData.metadata.id, { name: name_en, system: { description: { value: trait_en.system.description.value } } }, true) // characteristic-bonus text against the CURRENT locale's localized string
if (trait_fr?.name && trait_fr?.name != name_en) { // (wfrp4e.js: formula.replace(config.characteristicsBonus[ch].toLowerCase(), ...)),
//DEBUG : console.log(">>>>> Prayer ?", name_en, special, trait_fr.name ); // so a raw English "Willpower Bonus" formula throws a SyntaxError under a German
WFRP4FrTranslation.parseSpellContent(trait_en) // locale even when the prayer/spell itself isn't in our dictionary at all.
trait_fr.name = trait_fr.name || name_en WFRP4FrTranslation.parseSpellContent(trait_en)
trait_en.name = trait_fr.name + special; let trait_fr = __dictCaches.prayer?.get(name_en);
if (trait_fr.system?.description?.value) { if (trait_fr?.name) {
trait_en.system.description.value = trait_fr.system.description.value; trait_en.name = trait_fr.name + special;
} if (trait_fr.description) trait_en.system.description.value = trait_fr.description;
break;
}
} }
} else if (trait_en.type == "spell") { } else if (trait_en.type == "spell") {
let validCompendiums = game.wfrp4e.tags.getPacksWithTag("spell") WFRP4FrTranslation.parseSpellContent(trait_en)
for (let compData of validCompendiums) { let trait_fr = __dictCaches.spell?.get(name_en);
let trait_fr = game.babele.translate(compData.metadata.id, { name: name_en, system: { description: { value: trait_en.system.description.value } } }, true) if (trait_fr?.name) {
if (trait_fr?.name && trait_fr?.name != name_en) { trait_en.name = trait_fr.name + special;
//DEBUG : console.log(">>>>> Spell ?", name_en, special, trait_fr); if (trait_fr.description) trait_en.system.description.value = trait_fr.description;
WFRP4FrTranslation.parseSpellContent(trait_en)
trait_fr.name = trait_fr.name || name_en
trait_en.name = trait_fr.name + special;
if (trait_fr.system?.description?.value) {
trait_en.system.description.value = trait_fr.system.description.value;
}
break;
}
} }
} else if (trait_en.type == "talent") { } else if (trait_en.type == "talent") {
if (name_en.includes("(") && name_en.includes(")")) { // Then process specific skills name with (xxxx) inside if (name_en.includes("(") && name_en.includes(")")) { // Then process specific skills name with (xxxx) inside
@@ -481,65 +467,32 @@ Hooks.once('babele.init', () => {
special = " (" + game.i18n.localize(res[2].trim()) + ")"; // And the special keyword special = " (" + game.i18n.localize(res[2].trim()) + ")"; // And the special keyword
} }
} }
let validCompendiums = game.wfrp4e.tags.getPacksWithTag("talent") let talentKey = name_en;
for (let compData of validCompendiums) { if (talentKey === "Trapper") talentKey = "a7v422EZcOUUC20X";
if (name_en === "Trapper") { if (talentKey === "Inspiring") talentKey = "WCXnFSV4WOSmzzc4";
name_en = "a7v422EZcOUUC20X" let trait_fr = __dictCaches.talent?.get(talentKey);
} if (trait_fr?.name) {
if (name_en === "Inspiring") { trait_en.name = trait_fr.name.trim() + special
name_en = "WCXnFSV4WOSmzzc4" if (trait_fr.tests) trait_en.system.tests.value = trait_fr.tests;
} if (trait_fr.description) trait_en.system.description.value = trait_fr.description;
trait_en.name = name_en // Reset the name to the original one
let trait_fr = game.babele.translate(compData.metadata.id, trait_en, true)
if (trait_fr?.name && trait_fr?.name != name_en) {
trait_fr.name = trait_fr.name || name_en // Security since babele v10
//console.log(">>>>> Talent ?", trait_fr, name_en, special, trait_fr.name);
if (trait_fr.name && (trait_fr.name == "Sprinter" || trait_fr.name != name_en)) { // Talent translated!
trait_en.name = trait_fr.name.trim() + special
if (trait_fr.system?.tests?.value) { // Why ???
trait_en.system.tests.value = trait_fr.system.tests.value;
}
if (trait_fr.system?.description?.value) { // Why ???
trait_en.system.description.value = trait_fr.system.description.value;
}
}
break;
}
} }
} else if (trait_en.type == "career") { } else if (trait_en.type == "career") {
let validCompendiums = game.wfrp4e.tags.getPacksWithTag("career") let career_fr = __dictCaches.career?.get(name_en);
for (let compData of validCompendiums) { if (career_fr?.name) {
let career_fr = game.babele.translate(compData.metadata.id, trait_en, true); trait_en.name = career_fr.name
if (career_fr?.name && career_fr?.name != name_en) { if (career_fr.description) trait_en.system.description.value = career_fr.description;
trait_en.name = career_fr.name || trait_en.name
// DEBG: console.log(">>>>> Career ?", career_fr.name );
trait_en.system = foundry.utils.duplicate(career_fr.system);
break;
}
} }
} else if (trait_en.type == "vehicleRole") { } else if (trait_en.type == "vehicleRole") {
let validCompendiums = game.wfrp4e.tags.getPacksWithTag("vehicleRole") let role_fr = __dictCaches.vehicleRole?.get(name_en);
for (let compData of validCompendiums) { if (role_fr?.name) {
let role_fr = game.babele.translate(compData.metadata.id, trait_en, true); trait_en.name = role_fr.name
if (role_fr?.name && role_fr?.name != name_en) { if (role_fr.description) trait_en.system.description.value = role_fr.description;
trait_en.name = role_fr.name || trait_en.name
// DEBG: console.log(">>>>> Role ?", role_fr.name );
trait_en.system = foundry.utils.duplicate(role_fr.system);
break;
}
} }
} else if (trait_en.type == "trapping" || trait_en.type == "weapon" || trait_en.type == "armour" || trait_en.type == "container" || trait_en.type == "money") { } else if (trait_en.type == "trapping" || trait_en.type == "weapon" || trait_en.type == "armour" || trait_en.type == "container" || trait_en.type == "money") {
let validCompendiums = game.wfrp4e.tags.getPacksWithTag(["trapping"], ["weapon", "armour", "container", "money"]) let trapping_fr = __dictCaches.trapping?.get(name_en);
for (let compData of validCompendiums) { if (trapping_fr?.name) {
let trapping_fr = game.babele.translate(compData.metadata.id, { name: name_en, system: { description: { value: trait_en.system.description.value } } }, true); trait_en.name = trapping_fr.name
if (trapping_fr?.name && trapping_fr?.name != name_en) { if (trapping_fr.description) trait_en.system.description.value = trapping_fr.description;
//console.log(">>>>> Trapping ?", name_en, trapping_fr.name);
trait_en.name = trapping_fr.name || trait_en.name
if (trapping_fr.system?.description?.value) {
trait_en.system.description.value = trapping_fr.system.description.value
}
break;
}
} }
} }
} }
@@ -666,6 +619,20 @@ Hooks.once('babele.init', () => {
/*---------------------------------------------------------------------*/ /*---------------------------------------------------------------------*/
Hooks.once('ready', () => { Hooks.once('ready', () => {
// game.wfrp4e isn't guaranteed to exist yet during 'babele.init' (that hook can
// fire before the wfrp4e system finishes its own setup), so the dictionary
// caches are built here instead, once 'ready' guarantees game.wfrp4e is live.
// Exposed as a promise so other modules (addon-register.js's completion chat
// message) can wait for these fetches to genuinely finish before announcing
// the translation as fully loaded, instead of relying on a fixed timeout.
const dictCacheBuilds = ["career", "skill", "trait", "prayer", "spell", "talent", "vehicleRole"]
.map(tag => __buildDictCache(...game.wfrp4e.tags.getPacksWithTag(tag)).then(cache => { __dictCaches[tag] = cache; }));
dictCacheBuilds.push(
__buildDictCache(...game.wfrp4e.tags.getPacksWithTag(["trapping"], ["weapon", "armour", "container", "money"]))
.then(cache => { __dictCaches.trapping = cache; })
);
game.wfrp4efr.dictCachesReady = Promise.all(dictCacheBuilds);
console.log("WFRP4E-DE | Modul ist übersetzt."); console.log("WFRP4E-DE | Modul ist übersetzt.");
ui.notifications.info("WFRP4E-DE: Übersetzung ist fertig geladen."); ui.notifications.info("WFRP4E-DE: Übersetzung ist fertig geladen.");